Conversation
Member
Author
|
This only works after Rust 1.53, so I'm desugaring the or-patterns for now. |
rubdos
force-pushed
the
avatar-retention
branch
from
2c65081 to
69966b4
Compare
Member
Author
|
This seems to work well. |
gferon
approved these changes
Nov 13, 2022
Collaborator
gferon
left a comment
gferon
left a comment
There was a problem hiding this comment.
LGTM! I'm only starting to think that we should think twice before adding more primitive arguments to our function and maybe introduce types so we can add variants later, but here it's perfectly fine 👍🏼🥳
Member
Author
I agree. In this case, it makes the methods very Rusty, I feel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will test now.